From: | Yaroslav Saburov <y(dot)saburov(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, pgsql-docs(at)lists(dot)postgresql(dot)org |
Subject: | Re: generated constraint name |
Date: | 2025-04-11 08:32:45 |
Message-ID: | A76B1033-B4AE-4FE3-AC73-5B5303CF5071@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs |
Thank you all.
In order not to open a new thread, (small clarification)
On the tutorial-agg page in the code example
SELECT city FROM weather WHERE temp_lo = max(temp_lo); WRONG
you need to add a comment before WRONG
> 10 квіт. 2025 р. о 18:13 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> пише:
>
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>>> On 07.04.25 15:34, David G. Johnston wrote:
>>> I feel like that whole parenthetical should just go away. The point of
>>> the comment is to remind the user of how identifier values work with
>>> respect to mandatory double quoting. The name itself, other than having
>>> a $, has no special importance.
>
>> I think generated constraint names were generally "$1", "$2", etc. at
>> some point, instead of the more readable ones you get today. But this
>> must be ancient.
>
> Good point. A bit of git-blame'ing shows that this documentation
> wording appeared in e560dd353 of 2003-11-05, but we changed the
> generation rule to not be "$n" in 45616f5bb of 2004-06-10.
> (Oddly, I moved this documentation text around in 2005 without
> noticing it was obsolete; or perhaps I did realize that but figured
> it was still applicable to versions in the field.)
>
> I concur with David that we should just drop the para. It's merely
> confusing now. If you have a generated constraint name, it won't
> require double-quoting unless your table or column name does, and
> if they do you are doubtless already quite familiar with how
> quoting works.
>
> regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Euler Taveira | 2025-04-11 12:45:02 | Re: generated constraint name |
Previous Message | Tom Lane | 2025-04-10 15:13:00 | Re: generated constraint name |