Re: Writing a C function to return the log file name

From: Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>
To: "'Kouber Saparev *EXTERN*'" <kouber(at)gmail(dot)com>, "pgsql-general(at)postgresql(dot)org" <pgsql-general(at)postgresql(dot)org>
Subject: Re: Writing a C function to return the log file name
Date: 2017-06-06 15:56:11
Message-ID: A737B7A37273E048B164557ADEF4A58B53A53A1A@ntex2010i.host.magwien.gv.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

Kouber Saparev wrote:
> I am trying to write a function in C to return the log file name by given timestamp. I
> will use that later to make dynamic creation of a foreign table (file_fdw) to read the csv
> logs themselves. The thing is I do now want to hardcode neither the format, nor the
> directory in my extension.
>
> I already looked into the adminpack extension, but the format is hardcoded to the default
> one there, so it does not serve my needs.
>
> Here is what I currently have:
> https://gist.github.com/kouber/89b6e5b647452a672a446b12413e20cf
>
>
> The thing is the function is returning random results, obtained by pg_strftime().
>
> kouber=# select now()::timestamp, sqlog.log_path(now()::timestamp);
> NOTICE: Log directory = "pg_log"
> NOTICE: Log filename = "postgresql-%F.log"
> NOTICE: Length = "7"
> NOTICE: Filename = "pg_log/postgresql-17422165-04-30.log"
> now | log_path
> ----------------------------+--------------------------------------
> 2017-06-02 14:17:47.832446 | pg_log/postgresql-17422165-04-30.csv
> (1 row)
>
> kouber=# select now()::timestamp, sqlog.log_path(now()::timestamp);
> NOTICE: Log directory = "pg_log"
> NOTICE: Log filename = "postgresql-%F.log"
> NOTICE: Length = "7"
> NOTICE: Filename = "pg_log/postgresql-17422166-02-08.log"
> now | log_path
> ----------------------------+--------------------------------------
> 2017-06-02 14:18:12.390558 | pg_log/postgresql-17422166-02-08.csv
> (1 row)
>
>
>
>
>
> Any idea what am I doing wrong?
>
>
> I copied logfile_getname() from syslogger.c, and simply added some debug messages in
> there.

You are mixing up "Timestamp" and "pg_time_t".

Both are int64, but the former contains the number of microseconds since
2000-01-01 00:00:00, while the latter represents "the number of seconds
elapsed since 00:00:00 on January 1, 1970, Coordinated Universal Time (UTC)"
(quote from "man localtime").

Yours,
Laurenz Albe

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message tel medola 2017-06-06 18:09:12 Re: Redo the filenode link in tablespace
Previous Message Adrian Klaver 2017-06-06 13:37:12 Re: Redo the filenode link in tablespace