Re: Can SET_VARSIZE cause a memory leak?

From: Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>
To: '??????? ??????????' <nb(at)cobra(dot)ru>, "pgsql-general(at)postgresql(dot)org" <pgsql-general(at)postgresql(dot)org>
Subject: Re: Can SET_VARSIZE cause a memory leak?
Date: 2016-06-08 12:55:09
Message-ID: A737B7A37273E048B164557ADEF4A58B5385B1FA@ntex2010i.host.magwien.gv.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

Николай Бабаджанян wrote:
> I didn't find an easy way to convert ucs-2 bytea to utf-8, so I decided to write a C-function. Since
> ucs-2 is has fixed symbol size of 2 bytes the output bytea size may differ.
>
> I do the following:
>
> bytea *result= (bytea *) palloc0(VARSIZE(in_bytea)); // allocating memory for the result
> SET_VARSIZE(result, VARSIZE_ANY(in_bytea));
>
> ... // some calculations resulting in `result` having some trailing 0-s (since palloc0 was
> used). We don't need those, so:
>
> SET_VARSIZE(result, new_varsize_result+VARHDRSZ); // new_varsize_result was calculated during
> the convertion
>
> PG_RETURN_BYTEA_P(result);
>
> The question is am I leaking memory by doing this, and if I am, should I use pfree() manually on each
> address that is left trailing, or is there some other way to make this work?

This is safe, and the memory will be freed at the end of the transaction.

Yours,
Laurenz Albe

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Allan Kamau 2016-06-08 13:46:40 Full text search on Chemistry text
Previous Message Николай Бабаджанян 2016-06-08 11:47:29 [C-function] Can SET_VARSIZE cause a memory leak?