Re: Patch for pg_upgrade to turn off autovacuum

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch for pg_upgrade to turn off autovacuum
Date: 2011-04-22 01:38:47
Message-ID: A71F6AE6-792B-4977-9C6D-A82DD81DC831@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Apr 21, 2011, at 6:22 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Tom Lane wrote:
>> Bruce Momjian <bruce(at)momjian(dot)us> writes:
>>> Tom Lane wrote:
>>>> Huh? Why would that be? Seems like you've done something in the wrong
>>>> place if that's an issue.
>>
>>> Yeah, it is complicated. I don't really care if autovacuum runs on the
>>> old cluster (we only move the files while the server is down). We only
>>> want autovacuum not to mess with the relfrozenxids we set on the new
>>> cluster while the table file is empty.
>>
>>> The other issue is that the old alpha binary will not know about the -b
>>> flag and hence will not start.
>>
>> Well, once again, why are you trying to do that? It's not the source
>> postmaster that needs this flag.
>
> Well, consider that this also locks out non-super users so I figured it
> would be good to run the old and new in the same binary upgrade mode.
> Again, we can do just the new cluster for 9.1. I can also control the
> behavior based on the catalog version number, which seems the most
> logical.

I think you are over-engineering this. Just use it for the new cluster only, full stop, and you'll be right as rain.

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2011-04-22 03:42:07 Re: "stored procedures"
Previous Message Robert Haas 2011-04-22 01:34:57 Re: "stored procedures"