Re: [bug fix] multibyte messages are displayed incorrectly on the client

From: "MauMau" <maumau307(at)gmail(dot)com>
To: "Bruce Momjian" <bruce(at)momjian(dot)us>
Cc: "Noah Misch" <noah(at)leadboat(dot)com>, <alvherre(at)2ndquadrant(dot)com>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [bug fix] multibyte messages are displayed incorrectly on the client
Date: 2014-01-07 13:56:28
Message-ID: A641A0C673C94FCFA8F3A12886734274@maumau
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

From: "Bruce Momjian" <bruce(at)momjian(dot)us>
> On Sun, Jan 5, 2014 at 04:40:17PM +0900, MauMau wrote:
>> Then, as a happy medium, how about disabling message localization
>> only if the client encoding differs from the server one? That is,
>> compare the client_encoding value in the startup packet with the
>> result of GetPlatformEncoding(). If they don't match, call
>> disable_message_localization().
>
> I think the problem is we don't know the client and server encodings
> at that time.

I suppose we know (or at least believe) those encodings during backend
startup:

* client encoding - the client_encoding parameter passed in the startup
packet, or if that's not present, client_encoding GUC value.

* server encoding - the encoding of strings gettext() returns. That is what
GetPlatformEncoding() returns.

Am I correct?

Regards
MauMau

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-01-07 15:04:33 Re: generic pseudotype IO functions?
Previous Message Peter Eisentraut 2014-01-07 13:19:49 Re: [COMMITTERS] pgsql: Upgrade to Autoconf 2.69