| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | "alvherre(at)alvh(dot)no-ip(dot)org" <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "x4mmm(at)yandex-team(dot)ru" <x4mmm(at)yandex-team(dot)ru>, "a(dot)lubennikova(at)postgrespro(dot)ru" <a(dot)lubennikova(at)postgrespro(dot)ru>, "hlinnaka(at)iki(dot)fi" <hlinnaka(at)iki(dot)fi>, "matsumura(dot)ryo(at)fujitsu(dot)com" <matsumura(dot)ryo(at)fujitsu(dot)com>, "masao(dot)fujii(at)gmail(dot)com" <masao(dot)fujii(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: archive status ".ready" files may be created too early |
| Date: | 2021-08-23 15:57:13 |
| Message-ID: | A619E76E-FA05-43D3-B888-13101E4E5305@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 8/23/21, 8:50 AM, "alvherre(at)alvh(dot)no-ip(dot)org" <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> ... while reading the resulting code after backpatching to all branches,
> I realized that if there are no registrations whatsoever, then archiving
> won't do anything, which surely is the wrong thing to do. The correct
> behavior should be "if there are no registrations, then *all* flushed
> segments can be notified".
Hm. My expectation would be that if there are no registrations, we
cannot create .ready files for the flushed segments. The scenario
where I can see that happening is when a record gets flushed to disk
prior to registration. In that case, we'll still eventually register
the record and wake up the WAL writer process, which will take care of
creating the .ready files that were missed earlier. Is there another
case you are thinking of where we could miss registration for a cross-
segment record altogether?
Nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | alvherre@alvh.no-ip.org | 2021-08-23 16:31:48 | Re: archive status ".ready" files may be created too early |
| Previous Message | Chapman Flack | 2021-08-23 15:52:05 | Re: Mark all GUC variable as PGDLLIMPORT |