Re: Adding support for SSLKEYLOGFILE in the frontend

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Abhishek Chanda <abhishek(dot)becs(at)gmail(dot)com>
Cc: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Adding support for SSLKEYLOGFILE in the frontend
Date: 2025-03-03 15:23:12
Message-ID: A2EC022B-8EDB-4F62-8F93-7214ED3BE1EE@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 28 Feb 2025, at 07:20, Abhishek Chanda <abhishek(dot)becs(at)gmail(dot)com> wrote:
>
> Attached a v6 with O_NOFOLLOW removed, I noticed that it failed on
> windows. Please let me know if I should do this in any other way that
> is portable across platforms.

Not sure if there is a portable way to can support.

required version is 3.4 (from <systemitem class="osname">OpenBSD</systemitem>
- version 7.0).
+ version 7.5).
Bumping the version needs a bit more infrastructure than this. Doing a bit
more research unveiled that there is no need to do this though since LibreSSL
doesn't support keylogging at all, they have only implemented stubs for
compatibility. I've added checks to autoconf and meson to identify the
capability and conditional compilation of the support. The tests are also
updated to reflect this.

- bytes_written = dprintf(fd, "%s\n", line);
We use write(2) everywhere so I've changed to patch to do the same.

The attached 0002 also contains documentation touchups and comments etc. 0001
is your patch from v6.

--
Daniel Gustafsson

Attachment Content-Type Size
v7-0002-Review-fixups.patch application/octet-stream 9.3 KB
v7-0001-Add-support-for-dumping-SSL-keylog-to-a-file.patch application/octet-stream 8.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-03-03 15:49:30 Re: Options to control remote transactions’ access/deferrable modes in postgres_fdw
Previous Message torikoshia 2025-03-03 15:20:11 Re: Change log level for notifying hot standby is waiting non-overflowed snapshot