Re: PATCH: Fix the issue for saving query output as CSV

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Fix the issue for saving query output as CSV
Date: 2016-06-28 06:08:38
Message-ID: A2CB9EDB-316F-478E-BB0B-5C3FA1472FAC@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

Yes, Safari is exception case because it does not support download attribute of hyperlink <a> element.

Ref: http://caniuse.com/#feat=download

I was not able to find any workaround for Safari as of now that’s is why I mentioned only Firefox & IE in my last email,
Earlier it was only working on Chrome and with this patch it will work with Chrome/Firefox/IE.

Regards,
Murtuza

> On 27-Jun-2016, at 9:35 pm, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
> Hi
>
> On Mon, Jun 27, 2016 at 1:08 PM, Murtuza Zabuawala
> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>> Hi,
>>
>> PFA patch to fix the issue for downloading query output as CSV not working
>> in Firefox & IE.
>> Also fixes the issue that HTML tags were also appended in columns title in
>> CSV header.
>>
>> Browser side fix for -> RM#1405
>
> This works on Firefox and Chrome, but on Safari, clicking the button
> does nothing.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2016-06-28 06:22:18 Re: [pgAdmin4][Patch]: RM#1242 - Cleanup busy indication for tree view and tab panes
Previous Message Dave Page 2016-06-27 16:12:31 Re: [pgAdmin4][Patch]: RM#1242 - Cleanup busy indication for tree view and tab panes