Re: [PATCH] cleanup hashindex for pg_migrator hashindex compat mode (for 8.4)

From: Greg Stark <greg(dot)stark(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, David Fetter <david(at)fetter(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Dimitri Fontaine <dfontaine(at)hi-media(dot)com>, Kenneth Marshall <ktm(at)rice(dot)edu>, Zdenek Kotala <Zdenek(dot)Kotala(at)sun(dot)com>
Subject: Re: [PATCH] cleanup hashindex for pg_migrator hashindex compat mode (for 8.4)
Date: 2009-05-26 19:11:05
Message-ID: A2C1BB0E-F61F-4661-ACAC-5348CB7D0A45@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Uhm the rap you quoted was ambiguous but I read it as referring to the
ability I described if viewing the difference between two patches --
which I didn't name but is in fact interdiff.

--
Greg

On 26 May 2009, at 19:58, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>> Tom Lane escribió:
>>> IIRC it was demonstrated to be broken the last time it was proposed
>>> as a solution to our problems. Maybe it's been fixed since then,
>>> but
>>> I don't have any confidence in it, since evidently it's not been
>>> stress
>>> tested very hard.
>
>> I think you're probably confusing it with interdiff.
>
> No, because I never heard of interdiff before. Checking the archives,
> the discussion I was remembering was definitely about filterdiff, but
> the rap on it was undocumented (so maybe "demonstrated" is too harsh):
>
> http://archives.postgresql.org/pgsql-hackers/2007-10/msg01243.php
>
> regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-05-26 19:20:15 Re: generic options for explain
Previous Message Greg Stark 2009-05-26 19:04:26 Re: generic options for explain