Re: Incorrect link tohttps://www.postgresql.org/docs/current/indexes-functional.html ?

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: keiko(dot)cda(at)gmail(dot)com, pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: Incorrect link tohttps://www.postgresql.org/docs/current/indexes-functional.html ?
Date: 2023-05-06 20:08:36
Message-ID: A189C0E6-C849-4160-8C03-01DC617CF40B@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

> On 5 May 2023, at 15:42, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> This is actually not an error in the 7.3 docs (which we clearly wouldn't
>> address) but an error in pgweb in the warning for unsupported versions; it
>> assumes it can link to the same page in /current.
>
> Ah, good point. And it does know that the page doesn't exist in /current,
> because the "same page in other versions" list just above doesn't include
> that. Maybe we could have the link to "current" point to the docs top
> level instead of the specific page in such cases? Or simpler, just omit
> the "You may want to view the same page..." sentence altogether.

Since this particular page doesn't exist in any supported version, the text in
the box is actually wrong twice:

"You may want to view the same page for the current version, or one of the
other supported versions listed above instead."

Since we know when rendering the page which versions it does exist in we could
set one of three template variables:

exist_in_current
exist_in_supported
exist_in_unsupported

Depending on which is set we can choose the right text for the box. That being
said, we should probably move this to -www for exposure among those who
actually know the pgweb backend.

--
Daniel Gustafsson

In response to

Browse pgsql-docs by date

  From Date Subject
Next Message PG Doc comments form 2023-05-08 15:10:41 CREATE TABLE ... PARTITION OF ...
Previous Message Tom Lane 2023-05-05 13:42:43 Re: Incorrect link tohttps://www.postgresql.org/docs/current/indexes-functional.html ?