Re: MSFT compiler fixes + misc

From: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>
To: 'Magnus Hagander' <mha(at)sollentuna(dot)net>, Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: MSFT compiler fixes + misc
Date: 2004-04-05 01:13:09
Message-ID: A02DEC4D1073D611BAE8525405FCCE2B55F3E1@harris.memetrics.local
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

> A thought about this - how about converting pgpiperead() and
> pgpipewrite() into functions intead of macros (on win32 - still
> redifining them on != win32), mimicking the behaviour of read() and
> write()?

And #def'ing them to be read + write under win32? Don't want to change every
instance of read/write.

> Then we could do awya with the #ifdefs at the points where its
> used, and just expect the normal Unix behaviour?

I don't see that we do have any #ifdefs where its used.

Can't help but feel I've misinterpreted your message.

Cheers,
Claudio

---
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-04-05 02:49:14 Improve GUC USERLIMIT code
Previous Message Magnus Hagander 2004-04-04 20:08:04 New socket code for win32