Re: win32 patch: processCancelRequest/reaper (+ various minor cha

From: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>
To: "'pgsql-patches(at)postgresql(dot)org'" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: win32 patch: processCancelRequest/reaper (+ various minor cha
Date: 2004-01-12 07:46:27
Message-ID: A02DEC4D1073D611BAE8525405FCCE2B55F252@harris.memetrics.local
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


This time with a patch actually attached [doh!]

> -----Original Message-----
> From: Claudio Natoli
> Sent: Monday, 12 January 2004 6:45 PM
> To: 'pgsql-patches(at)postgresql(dot)org'
> Subject: win32 patch: processCancelRequest/reaper (+ various minor
> changes)
>
>
>
> For application to HEAD, pending community review.
>
> Briefly,
>
> [all] Removed call to getppid in SendPostmasterSignal,
> replacing with a PostmasterPid variable, which gets set
> (early) in PostmasterMain
> - Q: Is this ok? Specifically, does anything call this
> function where getppid would not be the postmaster?
>
> [fork/exec] Implements processCancelRequest by keeping an
> array of pid/cancel_key structs in shared mem
>
> [fork/exec] Moves AttachSharedMemoryAndSemaphores call for
> backends into SubPostmasterMain
>
> [win32] Implements reaper/waitpid by keeping an arrays of
> children pids,handles in postmaster local mem
> - this item is largely untested, for reasons which
> should be obvious, but appears sound
>
> [win32/all] Added extern for pgpipe in Win32 case, and
> changed the second pipe call (which seems to have been missed
> earlier) to pgpipe
>
> [win32] #define'd ftruncate to chsize in the Win32 case
>
> [win32] PG_USLEEP for Win32 has a misplaced paren. Fixed.
>
> [win32] DLLIMPORT handling for MingW case
>
> Cheers,
> Claudio
>

---
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>

Attachment Content-Type Size
diff7c.out application/octet-stream 19.7 KB

Browse pgsql-patches by date

  From Date Subject
Next Message Kris Jurka 2004-01-12 18:32:16 COPY allows parameters which corrupt output
Previous Message Claudio Natoli 2004-01-12 07:44:40 win32 patch: processCancelRequest/reaper (+ various minor changes )