| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] INSERT ON CONFLICT and partitioned tables |
| Date: | 2017-12-07 05:10:45 |
| Message-ID: | 9ff5515e-22b3-ead3-0410-97626657a5db@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017/12/02 2:57, Robert Haas wrote:
> On Fri, Dec 1, 2017 at 2:44 AM, Amit Langote
> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> I forgot to consider the fact that mtstate could be NULL in
>> ExecSetupPartitionTupleRouting(), so would result in dereferencing NULL
>> pointer when called from CopyFrom(), which fixed in the attached updated
>> patch.
>
> a ? b : false can more simply be spelled a && b.
>
> Committed after changing it like that, fixing the broken documentation
> build, and making minor edits to the comments and documentation.
Thanks for committing.
Regards,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2017-12-07 05:47:32 | Re: Add PGDLLIMPORT lines to some variables |
| Previous Message | Jeff Janes | 2017-12-07 04:51:16 | Re: Bitmap scan is undercosted? - boolean correlation |