Re: Add a hook to allow modification of the ldapbindpasswd

On 2023-03-15 We 18:18, Andrew Dunstan wrote:
>
>
> On 2023-03-15 We 17:50, Tom Lane wrote:
>> Andrew Dunstan<andrew(at)dunslane(dot)net> writes:
>>> pushed.
>> drongo is not happy with this, but I'm kind of baffled as to why:
>>
>> "c:\\prog\\bf\\root\\HEAD\\pgsql.build\\pgsql.sln" (default target) (1) ->
>> "c:\\prog\\bf\\root\\HEAD\\pgsql.build\\ldap_password_func.vcxproj" (default target) (60) ->
>> (Link target) ->
>> ldap_password_func.obj : error LNK2001: unresolved external symbol __imp_ldap_password_hook [c:\\prog\\bf\\root\\HEAD\\pgsql.build\\ldap_password_func.vcxproj]
>> .\\Release\\ldap_password_func\\ldap_password_func.dll : fatal error LNK1120: 1 unresolved externals [c:\\prog\\bf\\root\\HEAD\\pgsql.build\\ldap_password_func.vcxproj]
>>
>> The only obvious explanation for a link problem would be if the
>> variable's declaration were missing PGDLLIMPORT; but it's not.
>>
>>
>
>
> Ugh. Not batting 1000 today. Will investigate.
>
>
>

The issue was apparently that I had neglected to suppress building the
test module on MSVC if not configured to build with LDAP, since the hook
is only defined in that case. I have pushed a fix for that and drongo is
happy once more.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com