Re: Inconsistent syntax for NumericOnly grammar production

From: Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Inconsistent syntax for NumericOnly grammar production
Date: 2017-05-29 13:31:15
Message-ID: 9dd9dbcf-69aa-a093-e1d1-64007306678b@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 05/28/2017 11:16 PM, Tom Lane wrote:
> The inconsistency here means that you can do, for example,
>
> regression=# set random_page_cost = +4;
> SET
> regression=# set random_page_cost = 4.2;
> SET
>
> but not
>
> regression=# set random_page_cost = +4.2;
> ERROR: syntax error at or near "4.2"
> LINE 1: set random_page_cost = +4.2;
> ^
> Any objections to allowing "+ FCONST" here? I'm inclined to
> fix this and back-patch it as well.

Seems like the right thing to do; no objections here.
--
Vik Fearing +33 6 46 75 15 36
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2017-05-29 14:04:13 Fix a typo in execExpr.c
Previous Message Dave Cramer 2017-05-29 13:11:38 question about replication docs