Re: Efficient output for integer types

From: Tels <nospam-pg-abuse(at)bloodgate(dot)com>
To: David Fetter <david(at)fetter(dot)org>
Cc: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Efficient output for integer types
Date: 2019-09-23 08:28:09
Message-ID: 9cb0b9d6d98472d7d56dd6f78e9b40d4@bloodgate.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Moin,

On 2019-09-22 23:58, David Fetter wrote:
> On Sat, Sep 21, 2019 at 07:29:25AM +0100, Andrew Gierth wrote:
>> >>>>> "David" == David Fetter <david(at)fetter(dot)org> writes:

> Fixed.

Good work, more performance is sure nice :)

Noticed one more thing in the patch:

> - *start++ = *a;
> - *a-- = swap;
> + memcpy(pos - 2, DIGIT_TABLE + c, 2);
> + i += 2;
> }
> + else
> + *a = (char) ('0' + value2);
> +
> + return olength;
> }

The line "i += 2;" modifies i, but i is never used again nor returned.

Best regards,

Tels

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2019-09-23 09:16:17 Re: pgbench - allow to create partitioned tables
Previous Message Konstantin Knizhnik 2019-09-23 07:57:08 Re: Global temporary tables