Re: Show inline comments from pg_hba lines in the pg_hba_file_rules view

From: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Show inline comments from pg_hba lines in the pg_hba_file_rules view
Date: 2023-09-01 11:16:31
Message-ID: 9c26f891-203d-bda4-39a0-0753cdb4e901@uni-muenster.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 01.09.23 12:44, Michael Paquier wrote:
> I am not sure what you have in mind, but IMO any solution would live
> better as long as a solution is:
> - not linked to hba.c, handled in a separate code path.
> - linked to all configuration files where comments are supported, if
> need be.
If I understood you correctly: You mean an independent feature that i.e.
gets raw lines and parses the inline #comments.

Doing so we could indeed avoid the trouble of messing around with the
hba.c logic, and it would be accessible to other config files. Very
interesting thought! It sounds like a much more elegant solution.

> Perhaps others have more opinions.
> --
> Michael

If I hear no objections, I'll try to sketch it as you suggested.

Thanks again for the feedback

Jim

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2023-09-01 11:31:14 Re: generate syscache info automatically
Previous Message Vik Fearing 2023-09-01 10:50:08 Re: SQL:2011 application time