| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Tatsuro Yamada <tatsuro(dot)yamada(dot)tf(at)nttcom(dot)co(dot)jp>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Duplicate history file? |
| Date: | 2021-06-09 07:23:47 |
| Message-ID: | 9b1276a7-4568-2fc9-4807-c5d943c6dc4f@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/06/09 15:58, Tatsuro Yamada wrote:
> Hi
>
>> Thank you for fixing the patch.
>> The new patch works well in my environment. :-D
>
> This may not be important at this time since it is a
> PoC patch, but I would like to inform you that there
> was a line that contained multiple spaces instead of tabs.
>
> $ git diff --check
> src/backend/access/transam/xlogarchive.c:465: trailing whitespace.
> +
Even with the patch, if "test ! -f ..." is used in archive_command,
you may still *easily* get the trouble that WAL archiving keeps failing?
Instead, we should consider and document "better" command for
archive_command, or implement something like pg_archivecopy command
into the core (as far as I remember, there was the discussion about
this feature before...)?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2021-06-09 07:25:17 | Re: Transactions involving multiple postgres foreign servers, take 2 |
| Previous Message | Peter Eisentraut | 2021-06-09 07:21:45 | Re: DELETE CASCADE |