Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling)

From: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling)
Date: 2017-05-02 13:34:55
Message-ID: 9a581750-5687-76b0-78d0-5a79c8bfc6f5@commandprompt.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 05/02/2017 05:13 AM, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Thu, Apr 20, 2017 at 7:46 AM, Petr Jelinek
>> <petr(dot)jelinek(at)2ndquadrant(dot)com> wrote:
>>> DROP SUBSCRIPTION mysub NODROP SLOT;

> Having said that, I doubt that anyone would argue that CREATE USER is
> anything but legacy syntax, or that our more recent syntax designs aren't
> better models to follow.
>
> It's not quite too late to revisit the syntax of the log rep commands
> ... shall we add this as an open item?

I would think so. Just in reading this, even if we keep a similar syntax
it should be DROP SLOT NO or DROP SLOT FALSE.

JD

>
> regards, tom lane
>
>

--
Command Prompt, Inc. http://the.postgres.company/
+1-503-667-4564
PostgreSQL Centered full stack support, consulting and development.
Everyone appreciates your honesty, until you are honest with them.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-05-02 14:08:41 Re: logical replication and PANIC during shutdown checkpoint in publisher
Previous Message Tom Lane 2017-05-02 13:31:44 Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling)