From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Amul Sul <sulamul(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_combinebackup: correct code comment. |
Date: | 2025-04-15 13:41:22 |
Message-ID: | 9DB7FE97-6609-4159-8074-20E3426C6E3C@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 15 Apr 2025, at 14:41, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Tue, Apr 15, 2025 at 3:46 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>> On 15 Apr 2025, at 06:22, Amul Sul <sulamul(at)gmail(dot)com> wrote:
>>> Attached is a patch that corrects the code comment for
>>> process_directory_recursively() in pg_combinebackup, where the comment
>>> incorrectly refers to "output_directory" instead of the intended
>>> "input_directory".
>>
>> Agreed. The second paragraph in the comment also seem a bit odd, how about the
>> below while we are there fixing things?
>>
>> - * If processing is a user-defined tablespace, the tsoid should be the OID
>> + * If processing a user-defined tablespace, the tsoid should be the OID
>
> Yeah, I agree with both of these changes. Feel free to commit, unless
> you want me to do it.
No worries, I had this staged anyways from looking at Amul's patch so done as
7ae13170ba5 with a backpatch to 17 as it was a documentation fix and not just a
typo fix.
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | Kirill Reshke | 2025-04-15 14:00:21 | Re: speedup COPY TO for partitioned table. |
Previous Message | torikoshia | 2025-04-15 13:23:34 | Align memory context level numbering in pg_log_backend_memory_contexts() |