| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, David Rowley <dgrowleyml(at)gmail(dot)com>, Jacob Champion <jchampion(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: generic plans and "initial" pruning |
| Date: | 2023-07-03 13:27:22 |
| Message-ID: | 9D23D8BB-83EE-451E-95C1-CF42ADB76869@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 8 Jun 2023, at 16:23, Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
>
> Here is a new version.
The local planstate variable in the hunk below is shadowing the function
parameter planstate which cause a compiler warning:
@@ -1495,18 +1556,15 @@ ExecEndPlan(PlanState *planstate, EState *estate)
ListCell *l;
/*
- * shut down the node-type-specific query processing
- */
- ExecEndNode(planstate);
-
- /*
- * for subplans too
+ * Shut down the node-type-specific query processing for all nodes that
+ * were initialized during InitPlan(), both in the main plan tree and those
+ * in subplans (es_subplanstates), if any.
*/
- foreach(l, estate->es_subplanstates)
+ foreach(l, estate->es_inited_plannodes)
{
- PlanState *subplanstate = (PlanState *) lfirst(l);
+ PlanState *planstate = (PlanState *) lfirst(l);
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2023-07-03 13:27:27 | Re: Track Oldest Initialized WAL Buffer Page |
| Previous Message | Ashutosh Bapat | 2023-07-03 13:22:24 | Re: logicalrep_message_type throws an error |