| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Amul Sul <sulamul(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: new heapcheck contrib module |
| Date: | 2020-08-03 15:02:19 |
| Message-ID: | 9BE0DA14-0B5A-41DB-A613-2FDF72E98318@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Aug 2, 2020, at 9:13 PM, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>
> On Thu, Jul 30, 2020 at 10:59 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> I don't really like the name, either. I get that it's probably
>> inspired by Perl, but I think it should be given a less-clever name
>> like report_corruption() or something.
>
> +1 -- confess() is an awful name for this.
I was trying to limit unnecessary whitespace changes. s/ereport/econfess/ leaves the function name nearly the same length such that the following lines of indented error text don't usually get moved by pgindent. Given the unpopularity of the name, it's not worth it, so I'll go with Robert's report_corruption, instead.
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-08-03 15:06:40 | Re: [PATCH] - Provide robust alternatives for replace_string |
| Previous Message | Mark Dilger | 2020-08-03 14:42:19 | Re: new heapcheck contrib module |