Re: [v9.5] Custom Plan API

From: Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>
To: Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Stephen Frost" <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Andres Freund" <andres(at)2ndquadrant(dot)com>, PgHacker <pgsql-hackers(at)postgresql(dot)org>, "Jim Mlodgenski" <jimmy76(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: [v9.5] Custom Plan API
Date: 2014-07-15 12:37:47
Message-ID: 9A28C8860F777E439AA12E8AEA7694F8FBC682@BPXM15GP.gisp.nec.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> 2014-07-14 22:18 GMT+09:00 Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>:
> > Hanada-san,
> >
> > Thanks for your checking. The attached v4 patch is rebased one on the
> > latest master branch. Indeed, merge conflict was trivial.
> >
> > Updates from the v3 are below:
> > - custom-plan.sgml was renamed to custom-plan-provider.sgml
> > - fix up the comments in pg_custom_plan_provider.h that mentioned
> > about old field name.
> > - applied your patch to fix up typos. (thanks so much!)
> > - put "costs off" on the EXPLAIN command in the regression test of
> > ctidscan extension.
>
> Checked, but the patch fails sanity-check test, you need to modify expected
> file of the test.
>
Sorry, expected result of sanity-check test was not updated on
renaming to pg_custom_plan_provider.
The attached patch fixed up this point.

> > Nothing to comment on the design and implementation from your
> > viewpoint any more?
>
> As much as I can tell, the design seems reasonable. After fix for the small
> issue above, I'll move the patch status to "Ready for committer".
>

--
NEC OSS Promotion Center / PG-Strom Project
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>

Attachment Content-Type Size
pgsql-v9.5-custom-plan.v5.patch application/octet-stream 150.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2014-07-15 13:12:54 Re: SSL compression info in psql header
Previous Message Michael Paquier 2014-07-15 12:25:00 Re: Removing dependency to wsock32.lib when compiling code on WIndows