T_CustomScan on ExplainTargetRel

From: Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: T_CustomScan on ExplainTargetRel
Date: 2014-11-20 06:41:48
Message-ID: 9A28C8860F777E439AA12E8AEA7694F8010836AD@BPXM15GP.gisp.nec.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

The attached obvious patch adds T_CustomScan on case-switch of
ExplainTargetRel() that was oversight.

It looked like working, but what it did was just printing referenced
name, instead of table name.

postgres=# explain select ctid, * from t0 hoge where ctid > '(50,0)'::tid;
QUERY PLAN
------------------------------------------------------------------------
Custom Scan (ctidscan) on hoge (cost=0.00..100.00 rows=3333 width=43)
Filter: (ctid > '(50,0)'::tid)
ctid quals: (ctid > '(50,0)'::tid)
(3 rows)

This patch fixes up this behavior, as like other *Scan nodes are doing.

postgres=# explain select ctid, * from t0 hoge where ctid > '(50,0)'::tid;
QUERY PLAN
-------------------------------------------------------------
Seq Scan on t0 hoge (cost=0.00..209.00 rows=3333 width=43)
Filter: (ctid > '(50,0)'::tid)
(2 rows)

Thanks,
--
NEC OSS Promotion Center / PG-Strom Project
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>

Attachment Content-Type Size
pgsql-v9.5-fixup-customscan-on-explain-targetrel.patch application/octet-stream 457 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kouhei Kaigai 2014-11-20 06:44:25 Re: T_CustomScan on ExplainTargetRel
Previous Message Anssi Kääriäinen 2014-11-20 06:37:21 Re: INSERT ... ON CONFLICT {UPDATE | IGNORE}