| From: | Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Subject: | Re: wal stats questions |
| Date: | 2021-05-17 07:39:51 |
| Message-ID: | 99f964c6-5028-81ff-d7d3-51b864a05b01@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for your comments!
>> + * is executed, wal records aren't nomally generated (although HOT makes
>
> nomally -> normally?
Yes, fixed.
>> + * It's not enough to check the number of generated wal records, for
>> + * example the walwriter may write/sync the WAL although it doesn't
>
> You use both 'wal' and 'WAL' in the comments, but are there any intension?
No, I changed to use 'WAL' only. Although some other comments have 'wal' and
'WAL', it seems that 'WAL' is often used.
Regards,
--
Masahiro Ikeda
NTT DATA CORPORATION
| Attachment | Content-Type | Size |
|---|---|---|
| v9-0001-performance-improvements-of-reporting-wal-stats-without-introducing-a-new-variable.patch | text/x-patch | 9.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-05-17 07:44:11 | Re: Different compression methods for FPI |
| Previous Message | Dilip Kumar | 2021-05-17 07:36:58 | Re: [Patch] ALTER SYSTEM READ ONLY |