Re: includedir_internal headers are not self-contained

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Christoph Berg <cb(at)df7cb(dot)de>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: includedir_internal headers are not self-contained
Date: 2014-05-02 01:40:51
Message-ID: 9995.1398994851@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Tom Lane wrote:
>> The patch is certainly too invasive to consider back-patching into
>> 9.3, though.

> I feel unsure about this. I agree the patch is quite invasive. Leaving
> 9.3 in a broken state seems problematic. In particular I'm not sure
> what would Debian do about the whole issue; would they have to carry the
> patch for their 9.3 packages?

My recommendation to Christoph upthread was that they just look the
other way for the time being, ie, ignore the fact that relpath.h is
unusable by freestanding apps in 9.3. Backpatching what I did for
9.4 would be an ABI break, so that seems to me to be out of the
question in 9.3. And it's not clear that anybody outside core+contrib
really needs relpath.h yet, anyway. (Of course, you could argue that
if there are no external users then the ABI break isn't a problem;
but if there are, then it is.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2014-05-02 02:05:06 need xmllint on borka
Previous Message Alvaro Herrera 2014-05-02 01:33:02 Re: includedir_internal headers are not self-contained