Re: Various silliness in heap_getnext and related routines

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: bruc(at)acm(dot)org
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Various silliness in heap_getnext and related routines
Date: 2001-06-09 16:53:28
Message-ID: 9987.992105608@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

bruc(at)stone(dot)congenomics(dot)com (Robert E. Bruccoleri) writes:
> For my immediate problem, would removing the spinlock acquisition
> be OK?

It'd be interesting to remove the marked lines:

bufHdr = &BufferDescriptors[buffer - 1];
- SpinAcquire(BufMgrLock);
if (bufHdr->tag.blockNum == blockNumber &&
RelFileNodeEquals(bufHdr->tag.rnode, relation->rd_node))
{
- SpinRelease(BufMgrLock);
return buffer;
}
- return ReadBufferWithBufferLock(relation, blockNumber, true);

and see how that affects your performance issue, if at all.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2001-06-09 16:59:58 Re: [JDBC] unlink large objects
Previous Message Tom Lane 2001-06-09 16:50:23 Re: ERROR: Memory exhausted in AllocSetAlloc(909324558)