| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgbench regression test failure |
| Date: | 2017-09-12 19:28:35 |
| Message-ID: | 9953.1505244515@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
>> I have a serious, serious dislike for tests that seem to work until
>> they're run on a heavily loaded machine.
> I'm not that sure the error message was because of that.
No, this particular failure (probably) wasn't. But now that I've realized
that this test case is timing-sensitive, I'm worried about what will
happen when it's run on a sufficiently slow or loaded machine.
>> I would not necessarily object to doing something in the code that
>> would guarantee that, though.
> Hmmm. Interesting point.
It could be as simple as putting the check-for-done at the bottom of the
loop not the top, perhaps.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2017-09-12 19:34:03 | Re: Automatic testing of patches in commit fest |
| Previous Message | Tom Lane | 2017-09-12 19:22:10 | Re: psql - add special variable to reflect the last query status |