Re: pgsql: Improve pg_basebackup long file name test Windows robustness

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Improve pg_basebackup long file name test Windows robustness
Date: 2023-07-03 15:01:31
Message-ID: 98d7edb2-cfc0-d36d-a8cf-2bf2ff8e89f8@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


On 2023-07-03 Mo 10:51, Andrew Dunstan wrote:
>
>
> On 2023-07-03 Mo 10:19, Daniel Gustafsson wrote:
>>> On 3 Jul 2023, at 16:08, Andrew Dunstan<andrew(at)dunslane(dot)net> wrote:
>>>
>>> Improve pg_basebackup long file name test Windows robustness
>>>
>>> Creation of a file with a very long name can create problems on Windows
>>> due to its file path limits. Work around that by creating the file via a
>>> symlink with a shorter name.
>> +dir_symlink "$pgdata", "$lftmp/pgdata";
>>
>> dir_symlink doesn't exist in REL_12_STABLE.
>
>
> Argh!. ok, thanks, will fix.
>
>
>

Neither does rel 13 have it. I've reverted all this for versions older
than 14. It means running TAP tests on older version on Windows could be
fragile, but at least my animals don't run TAP tests on older versions.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tomas Vondra 2023-07-03 16:46:04 pgsql: Remove expensive test of postgres_fdw batch inserts
Previous Message Andrew Dunstan 2023-07-03 14:58:46 pgsql: Revert "Improve pg_basebackup long file name test Windows robust