Re: Proposed patch - psql wraps at window width

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Gregory Stark <stark(at)enterprisedb(dot)com>
Cc: "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Bruce Momjian" <bruce(at)momjian(dot)us>, "Peter Eisentraut" <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, "Aidan Van Dyk" <aidan(at)highrise(dot)ca>, "Brendan Jurd" <direvus(at)gmail(dot)com>, "Bryce Nesbitt" <bryce2(at)obviously(dot)com>, heikki(at)enterprisedb(dot)com
Subject: Re: Proposed patch - psql wraps at window width
Date: 2008-04-24 22:38:11
Message-ID: 9886.1209076691@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> "Alvaro Herrera" <alvherre(at)commandprompt(dot)com> writes:
>> On what platforms does ioctl() fail?

> On ssh for example.

That'd certainly be a showstopper if true, but it seems to be okay for
me. ssh'ing from an xterm window, and running psql on the remote side,
I can see with gdb that ioctl(TIOCGWINSZ) succeeds and gives a result
that correctly tracks window resizes --- indeed there are several bits
of psql that I'd never have committed if they didn't work in this
environment, because it's been my everyday work environment for years.

Maybe you are used to an ancient ssh version?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Treat 2008-04-25 01:59:57 Re: MERGE Specification
Previous Message Gregory Stark 2008-04-24 22:35:33 Re: Proposed patch - psql wraps at window width

Browse pgsql-patches by date

  From Date Subject
Next Message Gregory Stark 2008-04-25 05:04:38 Re: Proposed patch - psql wraps at window width
Previous Message Gregory Stark 2008-04-24 22:16:17 Re: Proposed patch - psql wraps at window width