From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
Cc: | "Bruce Momjian" <bruce(at)momjian(dot)us>, "Jeremy Drake" <pgsql(at)jdrake(dot)com>, "PostgreSQL Hackers" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: src/tools/msvc usage instructions |
Date: | 2006-10-03 19:03:07 |
Message-ID: | 9878.1159902187@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
>> Or add a configure test to prevent it, and display a proper
>> error message.
> Yeha, I will do this.
As long as we're touching that code: the existing test for too-old bison
seriously sucks, because all that it does is to print a warning that
most people will never notice among all the other spewage from
configure. However, erroring out is not better, because for people
who're building from a tarball it won't matter what they have. The
Right Thing is to print a warning and set up for the "missing" script to
be invoked instead of bison if the files actually need to be built.
It looks like all that's needed is to reset YACC to "" after determining
that it's the wrong version, but that should be tested.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2006-10-03 19:04:31 | Re: src/tools/msvc usage instructions |
Previous Message | Simon Riggs | 2006-10-03 18:53:29 | Tsearch2 and Snowball |