| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Improve BRIN minmax-multi opclass test coverage |
| Date: | 2023-11-23 07:46:14 |
| Message-ID: | 98683303-b841-42a1-8ccc-9655b116ce24@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 22.08.23 08:43, Peter Eisentraut wrote:
> These new tests introduced a few new calls of the md5() function. This
> should be avoided (see commit 208bf364a9). You can replace these easily
> with the fipshash() function instead, but I think you then also need to
> change some of the constants in the tests. Could you look at this again?
I have created a patch that updates the test accordingly. It replaces
the md5() function with fipshash() and adjusts the test values to
correspond to the values generated in the original tests.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Use-fipshash-in-brin_multi-test.patch | text/plain | 8.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2023-11-23 11:33:23 | pgsql: Fix resource leak when a FDW's ForeignAsyncRequest function fail |
| Previous Message | Bruce Momjian | 2023-11-23 04:41:39 | pgsql: C comment: fix typos with unnecessary apostrophes |