| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Query tool execute to file prompting |
| Date: | 2010-03-30 15:34:59 |
| Message-ID: | 9837222c1003300834x47de908fsb0efcea27a0a5ef9@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi!
This patch attempts to address the issue that at least I've heard a
couple of time, of that the "execute to file" feature doesn't prompt
for the filename until after it's finished. This is quite annoying
when running multi-hour queries.
Other than a review please, I couldn't find where we actually destroy
the QueryExecInfo object allocated in frmQuery::execQuery(). It gets
picked up in OnQueryComplete(), but I don't see a delete anywhere. Is
it automatically deleted by the wx stuff (in which case I have a leak
of qi->toFileExportForm that I have to take care of), or do we have a
leak there today (in which case I have that leak to take care of :D).
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| Attachment | Content-Type | Size |
|---|---|---|
| exectofile.patch | application/octet-stream | 3.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2010-03-31 10:01:36 | Re: Query tool execute to file prompting |
| Previous Message | Guillaume Lelarge | 2010-03-29 22:17:37 | Re: Rework of the frmOptions window |