Re: mailing list archiver chewing patches

On Sun, Jan 31, 2010 at 15:09, Matteo Beccati <php(at)beccati(dot)com> wrote:
> On 31/01/2010 13:45, Magnus Hagander wrote:
>>
>> On Sat, Jan 30, 2010 at 22:43, Matteo Beccati<php(at)beccati(dot)com>  wrote:
>>>
>>> On 30/01/2010 17:54, Alvaro Herrera wrote:
>>>>
>>>> * While I don't personally care, some are going to insist that the site
>>>> works with Javascript disabled.  I didn't try but from your description
>>>> it doesn't seem like it would.  Is this easily fixable?
>>>
>>> Date sorting works nicely even without JS, while thread sorting doesn't
>>> at
>>> all. I've just updated the PoC so that thread sorting is not available
>>> when
>>> JS is not available, while it still is the default otherwise. Hopefully
>>> that's enough to keep JS haters happy.
>>
>> I haven't looked at how it actually works, but the general requirement
>> is that it has to *work* without JS. It doesn't have to work *as
>> well*. That means serving up a page with zero contents, or a page that
>> you can't navigate, is not acceptable. Requiring more clicks to get
>> around the navigation and things like that, are ok.
>
> As it currently stands, date sorting is the default and there are no links
> to the thread view, which would otherwise look empty. We can surely build a
> non-JS thread view as well, I'm just not sure if it's worth the effort.

Hmm. I personally think we need some level of thread support for
non-JS as well, that's at least not *too* much of a step backwards
from what we have now. But others may have other thoughts about that?

>>>> * We're using Subversion to keep the current code.  Is your code
>>>> version-controlled?  We'd need to import your code there, I'm afraid.
>>>
>>> I do have a local svn repository. Given it's just a PoC that is going to
>>> be
>>> rewritten I don't think it should live in the official repo, but if you
>>> think id does, I'll be glad to switch.
>>
>> Note that the plan is to switch pgweb to git as well. So if you just
>> want to push the stuff up during development so people can look at it,
>> register for a repository at git.postgresql.org - or just set one up
>> at github which is even easier.
>
> The only reason why I used svn is that git support in netbeans is rather
> poor, or at least that was my impression. I think it won't be a problem to
> move to git, I probably just need some directions ;)

:-)

Well, it doesn't matter what type of repo it's in at this point, only
once it goes into production. The reason I suggested git at this point
is that we (the postgresql project) do provide git hosting at
git.postgresql.org, but we don't provide subversion anywhere. And I'm
certainly not going to suggest you use pgfoundry and cvs....

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/