From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Define INADDR_NONE on Solaris when it's missing. |
Date: | 2010-01-28 20:19:34 |
Message-ID: | 9837222c1001281219n19384ae7k26fe0283395982e9@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Thu, Jan 28, 2010 at 21:16, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Thu, Jan 28, 2010 at 17:16, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> However, now that I know the real issue is you're using inet_addr, I
>>> would like to know why you're not using inet_aton instead; or even
>>> better, something that also copes with IPv6.
>
>> "Path of least resistance?"
>
>> Which method would you suggest?
>
> I haven't actually read the RADIUS patch, but generally we rely on
> pg_getaddrinfo_all to interpret strings representing IP addresses.
> Is there a reason not to use that?
I don't think so. I'll look it over.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2010-01-28 23:06:09 | pgsql: Fix bug found by warning from recent gcc. |
Previous Message | Tom Lane | 2010-01-28 20:16:24 | Re: pgsql: Define INADDR_NONE on Solaris when it's missing. |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2010-01-28 20:56:04 | remove contrib/xml2 |
Previous Message | Tom Lane | 2010-01-28 20:16:24 | Re: pgsql: Define INADDR_NONE on Solaris when it's missing. |