From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Greg Smith <greg(at)2ndquadrant(dot)com> |
Cc: | Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Clearing global statistics |
Date: | 2010-01-19 14:12:21 |
Message-ID: | 9837222c1001190612o1dbbac7esd515abd75afee694@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Jan 18, 2010 at 11:02, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Mon, Jan 18, 2010 at 00:52, Greg Smith <greg(at)2ndquadrant(dot)com> wrote:
>> Magnus Hagander wrote:
>>>
>>> Maybe this should be "Unrecognized reset target: %s", target, and also
>>> a errhint() saying which targets are allowed. Thoughts?
>>>
>>
>> That seems reasonable. The other thing I realized is that I forgot to add
>> the new function to the right place in doc/src/sgml/func.sgml :
>>
>> <indexterm>
>> <primary>pg_stat_reset_shared</primary>
>> </indexterm>
>>
>> I can send an updated patch with both of these things fixed tomorrow. Given
>> that we're talking 5 lines of change here, if it's easier for you to just
>> patch a working copy you've already started on that's fine too.
>
> I can deal with that, I just wanted to make sure we're in agreement.
Applied with agreed upon change and some minor styling/formatting changes.
The mention you have about documentation above is incorrect - the
other pg_stat_xyz functions aren't listed there, so neither should
this one. At least from AFAICT ;)
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2010-01-19 14:49:21 | Re: attoptions |
Previous Message | Leonardo F | 2010-01-19 12:08:55 | Re: Review: Patch: Allow substring/replace() to get/set bit values |