Re: win32 socket definition

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: win32 socket definition
Date: 2010-01-03 19:13:28
Message-ID: 9837222c1001031113r1de24a99ld7845d3ef5e69a95@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jan 3, 2010 at 17:45, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On fre, 2010-01-01 at 20:25 +0100, Magnus Hagander wrote:
>> The win64 port has showed that we have two sockets declared
>> incorrectly. They are supposed to be declared as SOCKET on win32, but
>> they are declared as int. See attached patch.
>>
>> Given that SOCKET is actually defined as int on win32 (no warnings or
>> anything there, just on win64), I'm inclined to apply this patch just
>> to HEAD and not bother with backpatching.
>
> What is SOCKET defined as on win64?

The socket definition is the same:
typedef UINT_PTR SOCKET;

But since it's defined as a pointer type, that makes it 64-bit on win64.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2010-01-03 19:40:02 Re: PATCH: Add hstore_to_json()
Previous Message Robert Haas 2010-01-03 19:06:04 Re: [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns