Re: WIP - syslogger infrastructure changes

On Sat, Sep 26, 2009 at 17:43, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Fri, Sep 25, 2009 at 5:22 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> AIUI the problem is that when logging_collector is on, we throw away
>>> the original stderr.  That's OK as long as you never try to switch
>>> back to it.
>
>> BTW, this seems like it could be fixed with some appropriate file
>> descriptor management in postmaster.  No?
>
> Yeah, probably.  In the current system design it didn't seem to be
> necessary because collecting the collector process's own stderr output
> is usually not all that critical.  If we had the postmaster dup its
> original stderr and the collector dup it back, that would be a more
> complete but more complex solution.  (dup2 works on Windows, no?)

Yeah, they should.

Not sure how that works through process boundaries though, we do some
special fiddling for any handles that need to be inherited.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/