Re: pgsql: Derived files that are shipped in the distribution used to be

On Sat, Aug 29, 2009 at 05:26, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> petere(at)postgresql(dot)org (Peter Eisentraut) writes:
>> Log Message:
>> -----------
>> Derived files that are shipped in the distribution used to be built in the
>> source directory even for out-of-tree builds.  They are now alsl built in
>> the build tree.  This should be more convenient for certain developers'
>> workflows, and shouldn't really break anything else.
>
> Seems to have broken the MSVC build ...

This is the part that broke it:
diff --git a/src/interfaces/ecpg/preproc/Makefile
b/src/interfaces/ecpg/preproc/Makefile
index fc7dcf5..f14a833 100644
--- a/src/interfaces/ecpg/preproc/Makefile
+++ b/src/interfaces/ecpg/preproc/Makefile
@@ -57,7 +57,7 @@ preproc.y: ../../../backend/parser/gram.y parse.pl
ecpg.addons ecpg.header ecpg.

ecpg_keywords.o c_keywords.o keywords.o preproc.o parser.o: preproc.h

-kwlookup.c: % : ../../../backend/parser/%
+kwlookup.c: % : $(top_srcdir)/src/backend/parser/%
rm -f $@ && $(LN_S) $< .

distprep: preproc.y preproc.c preproc.h pgc.c

Should I revert this, or are you planning a proper fix?

(I notice this construct is only used here, the working kind is still
used in bin/scripts and bin/psql)

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/