Re: refactoring basebackup.c

From: tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Dipesh Pandit <dipesh(dot)pandit(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: refactoring basebackup.c
Date: 2022-01-27 17:08:15
Message-ID: 97b377c3-15b9-517f-1fca-8b4150978e91@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/27/22 10:17 PM, Robert Haas wrote:
> Cool. I committed that patch.
Thanks , Please refer to this scenario  where the label is set to  0 for
server-gzip but the directory is still  compressed

[edb(at)centos7tushar bin]$ ./pg_basebackup -t server:/tmp/11 --gzip
--compress=0 -Xnone
NOTICE:  all required WAL segments have been archived
[edb(at)centos7tushar bin]$ ls /tmp/11
16384.tar  backup_manifest  base.tar

[edb(at)centos7tushar bin]$ ./pg_basebackup -t server:/tmp/10 --gzip
--compress=server-gzip:0 -Xnone
NOTICE:  all required WAL segments have been archived
[edb(at)centos7tushar bin]$ ls /tmp/10
16384.tar.gz  backup_manifest  base.tar.gz

0 is for no compression so the directory should not be compressed if we
mention server-gzip:0 and both these
above scenarios should match?

--
regards,tushar
EnterpriseDB https://www.enterprisedb.com/
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-01-27 17:42:39 Re: refactoring basebackup.c
Previous Message Robert Haas 2022-01-27 16:47:47 Re: refactoring basebackup.c