| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>, "pgsql-hackers(at)postgreSQL(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add PGDLLEXPORT to PG_FUNCTION_INFO_V1 |
| Date: | 2016-10-18 14:58:04 |
| Message-ID: | 979.1476802684@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Craig Ringer <craig(at)2ndquadrant(dot)com> writes:
> On 18 October 2016 at 04:19, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> On 2016-10-17 16:16:37 -0400, Robert Haas wrote:
>>> I wouldn't think that cross-file references would be especially
>>> common. Functions that take PG_FUNCTION_ARGS and return Datum aren't
>>> a lot of fun to call from C. But maybe I'm wrong.
>> There's a fair number of DirectFunctionCall$Ns over the backend.
> It's only an issue if one contrib calls another contrib (or the core
> backend code calls into a contrib, but that's unlikely) via
> DirectFunctionCall .
No, it's cross *file* references within a single contrib module that
would be likely to need extern declarations in a header file. That's
not especially weird IMO. I'm not sure how many cases there actually
are though.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-10-18 15:39:17 | Re: Partition-wise join for join between (declaratively) partitioned tables |
| Previous Message | Tom Lane | 2016-10-18 14:55:39 | Re: Add PGDLLEXPORT to PG_FUNCTION_INFO_V1 |