Re: pgsql: Trial fix for old cross-version upgrades.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: Jeff Davis <jdavis(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Trial fix for old cross-version upgrades.
Date: 2025-02-22 15:16:43
Message-ID: 976dcc37-b629-490e-a052-a057477d062f@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


On 2025-02-21 Fr 10:11 PM, Tom Lane wrote:
> Jeff Davis <pgsql(at)j-davis(dot)com> writes:
>> In 002_pg_upgrade.pl, I disabled autovacuum and restarted after the
>> regression run. In other words, in the old cluster, autovacuum did have
>> a chance to run, just not after the first dumpall.
> The hack I posted should prevent autovacuum from running either
> before or after dumping, in either cluster.
>
> However, it occurred to me to try forcing a HEAD-to-HEAD upgrade,
> a case the buildfarm animals have not been able to reach.
> And *it failed*!? (Diffs attached.) So that eliminates the
> theory that this is a cross-version compatibility problem, or
> at least that is not our only problem. It seems there is
> something different between what TestUpgradeXversion.pm is doing
> and what 002_pg_upgrade.pl is doing. No clue what, although it
> does look like an additional round of analyze'ing has added more
> stats than were there before.
>
>

Yeah, I don't know.

Here's what I have so far:

. for HEAD/18 disable running the analyze script / vacuumdb --analyze.

. turn off autovacuum on the old and upgraded database.

. reverse the order of testing so we do newest first

What I'm thinking of doing is running all the eligible upgrades rather
than stopping on the first failure.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2025-02-22 18:34:51 Re: pgsql: Trial fix for old cross-version upgrades.
Previous Message Álvaro Herrera 2025-02-22 09:06:07 pgsql: Change \conninfo to use tabular format