Re: Support custom socket directory in pg_upgrade

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Support custom socket directory in pg_upgrade
Date: 2018-12-01 20:48:27
Message-ID: 9753.1543697307@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 30/11/2018 17:58, Tom Lane wrote:
>> Given that we have a patch for this approach, and no patch has been
>> offered for the /tmp approach, I'm kind of inclined to exercise
>> committer's discretion and proceed with this patch. Will anybody
>> be seriously annoyed if I do?

> I think it's fair to proceed and leave open that someone submits a
> (possibly) better patch for a different approach in the future.

I don't think we'd be able to remove the --socketdir switch once added,
but certainly it doesn't preclude changing the algorithm for default
socket placement.

Pushed with minor code cleanup.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Verite 2018-12-01 21:11:16 Re: Markdown format output for psql, design notes
Previous Message Daniel Verite 2018-12-01 20:08:19 Re: [HACKERS] Can ICU be used for a database's default sort order?