| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dave Page <dpage(at)pgadmin(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Subject: | Re: Revoke execution permission of pg_stat_statements_reset() from pg_read_all_stats role |
| Date: | 2018-09-24 16:02:35 |
| Message-ID: | 9751.1537804955@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> This should be back-patched. Any opinions about bumping up this
> extension version in back-branches like what has been done in 53b79ab4?
Yes, you need to bump the extension version to change anything in the
extension's script file.
For v10 and up, the method used in 53b79ab4 is overcomplicated: you only
need to add a delta script not a new base script. (If you had to
back-patch before v10, it might be best to add a new base script in all
the branches just to keep the patches consistent; but IIUC this issue only
arises in v10 and up.) I'd consider following, eg, 7f563c09f as a
prototype instead.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-09-24 16:17:40 | Re: Missing const in DSA. |
| Previous Message | Alvaro Herrera | 2018-09-24 15:58:09 | Re: Segfault when creating partition with a primary key and sql_drop trigger exists |