| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
| Cc: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Unable parse a comment in gram.y |
| Date: | 2024-06-23 16:59:57 |
| Message-ID: | 973933.1719161997@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"David G. Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> writes:
> On Saturday, June 22, 2024, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> wrote:
>>> Perhaps s/As func_expr/Like func_expr/ would be less confusing?
>> +1. It's easier to understand at least for me.
> +1
OK. I looked through the rest of src/backend/parser/ and couldn't
find any other similar wording. There's plenty of "As with ..."
and "As in ...", but at least to me those don't seem confusing.
I'll plan to push the attached after the release freeze lifts.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| improve-comment-in-gram.y.patch | text/x-diff | 597 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema-Nio | 2024-06-23 22:59:48 | Re: [EXTERNAL] Re: Add non-blocking version of PQcancel |
| Previous Message | Alexander Lakhin | 2024-06-23 13:00:01 | Re: recoveryCheck/008_fsm_truncation is failing on dodo in v14- (due to slow fsync?) |