| From: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | gparc(at)free(dot)fr, pgsql-bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #18295: In PostgreSQL a unique index on targeted columns is sufficient to support a foreign key |
| Date: | 2024-01-29 08:59:05 |
| Message-ID: | 971235d021e8b501e8a5d1bb4b07309767800d96.camel@cybertec.at |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Thanks for your updated patch!
On Mon, 2024-01-29 at 21:42 +1300, David Rowley wrote:
> I also ended up fiddling with the "foreign-key" vs "foreign key"
> thing. I didn't expect you to change the existing ones and on changing
> the new one to "foreign-key", I thought it looked weird. Maybe we
> need a master-only patch to make these consistent...
Hm. With your changes, the title reads "Foreign-Key Constraints", but
the body uses "foreign key constraint". I think they should be consistent.
I'd be happy with either variant, but since the hyphenated version
isn't used anywhere else on the page, my opinion is that we should do
away with it.
Other than that, your patch looks good to me.
Yours,
Laurenz Albe
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2024-01-29 09:24:39 | Re: BUG #18280: logical decoding build wrong snapshot for subtransactions |
| Previous Message | David Rowley | 2024-01-29 08:42:36 | Re: BUG #18295: In PostgreSQL a unique index on targeted columns is sufficient to support a foreign key |