Re: pgsql: Remove unused wait events.

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <akapila(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Remove unused wait events.
Date: 2021-10-25 18:03:54
Message-ID: 97058FA5-5B76-4FD4-B741-9A39E7544EE6@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

> On 25 Oct 2021, at 20:01, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> On 2021-10-25 13:39:44 -0400, Tom Lane wrote:
>> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>>> Since this will cause integer values to have different textual enum value
>>> representations in 14 and 15+, do we want to skip two numbers by assigning the
>>> next wait event the integer value of WAIT_EVENT_WAL_WRITE incremented by three?
>>> Or enum integer reuse not something we guarantee against across major versions?
>>
>> We require a recompile across major versions. I don't see a reason why
>> this particular enum needs more stability than any other one.
>
> +1. That'd end up pushing us to be more conservative about defining new wait
> events, which I think would be bad tradeoff.

Fair enough, makes sense.

--
Daniel Gustafsson https://vmware.com/

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2021-10-25 20:31:46 pgsql: Initialize variable to placate compiler.
Previous Message Andres Freund 2021-10-25 18:01:22 Re: pgsql: Remove unused wait events.

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2021-10-25 18:10:54 Re: Predefined role pg_maintenance for VACUUM, ANALYZE, CHECKPOINT.
Previous Message Andres Freund 2021-10-25 18:01:22 Re: pgsql: Remove unused wait events.