| From: | Ildar Musin <i(dot)musin(at)postgrespro(dot)ru> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Add general purpose hasing functions to pgbench. |
| Date: | 2018-03-22 18:52:48 |
| Message-ID: | 96ddca3b-3f30-4fd8-1ad2-205dcd93154e@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Hello all,
22/03/2018 19:31, Fabien COELHO пишет:
>>>
>>> Looks to me like the constants need to be written with INT64CONST().
>>> Also, the fact that the added regression test is passing makes me
>>> wonder whether it's actually exercising these functions meaningfully.
>
> I think that there is at least some coverage
> (https://coverage.postgresql.org/src/bin/pgbench/pgbench.c.gcov.html)
> and the function results are also checked for some values in the perl
> script output.
>
As Fabien said output values for some particular inputs are checked in
tests. The fact that test passed apparently shows that compiler is smart
enough to recognize those constants as 'long long' and use them
accordingly in expressions.
--
Ildar Musin
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-03-22 19:06:51 | pgsql: Add helpers for emitting LLVM IR. |
| Previous Message | Andres Freund | 2018-03-22 18:43:41 | Re: pgsql: Add \if support to pgbench |