| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Hamid Akhtar <hamid(dot)akhtar(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: improving basebackup.c's file-reading code |
| Date: | 2020-06-25 14:29:48 |
| Message-ID: | 96F2A9C6-F184-448F-AEED-912860BBE15D@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 17 Jun 2020, at 17:45, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Wed, Apr 29, 2020 at 5:52 AM Hamid Akhtar <hamid(dot)akhtar(at)gmail(dot)com> wrote:
>> The idea and the patch looks good to me.
>>
>> It makes sense to change fread to basebackup_read_file which internally calls pg_pread which is a portable function as opposed to read. As you've mentioned, this is much better for error handling.
>
> Thanks for the review. I have now committed the patch, after rebasing
> and adjusting one comment slightly.
As this went in, can we close the 2020-07 CF entry or is there anything left in
the patchseries?
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2020-06-25 14:51:11 | Re: Why forbid "INSERT INTO t () VALUES ();" |
| Previous Message | Tom Lane | 2020-06-25 14:13:00 | Re: More tzdb fun: POSIXRULES is being deprecated upstream |