Andres Freund <andres(at)anarazel(dot)de> writes:
> Obviously that approach could be re-implemented for CI, but givent that it
> additionally is somewhat required to make use of headerscheck/cpluspluscheck
> locally, it feels better to solve it in headerscheck. And the easiest way for
> that seems to be -Werror?
Agreed --- although right now, headerscheck goes out of its way to be
agnostic about what compiler and cflags are used. Having it assume
that -Werror will work seems a bit ugly. Not sure that it's a problem
in practice though.
(BTW, we'll have to fix these scripts sometime to work in non-Make
builds.)
regards, tom lane